wu-sheng commented on a change in pull request #4353: Optimizing performance
reduces es index queries scope by timebucket
URL: https://github.com/apache/skywalking/pull/4353#discussion_r378070209
##########
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/DurationUtils.java
##########
@@ -213,4 +213,36 @@ private DateTime parseToDateTime(Downsampling
downsampling, long time) {
}
throw new UnexpectedException("Unexpected downsampling: " +
downsampling.name());
}
+
+ public DateTime startTimeBucket2DateTime(Downsampling downsampling, long
startTB) {
Review comment:
First, time covert should be inside `TimeBucket`, take a look at InfluxDB,
https://github.com/apache/skywalking/pull/4239/files#diff-df3b7b3f55b25fb0e29e345e7e6cc078.
Maybe good for you.
I think you don't need the `DateTime`? Directly convert to long as day/month
makes more sense?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
