aderm commented on a change in pull request #4353: Optimizing performance reduces es index queries scope by timebucket URL: https://github.com/apache/skywalking/pull/4353#discussion_r378083903
########## File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/DurationUtils.java ########## @@ -213,4 +213,36 @@ private DateTime parseToDateTime(Downsampling downsampling, long time) { } throw new UnexpectedException("Unexpected downsampling: " + downsampling.name()); } + + public DateTime startTimeBucket2DateTime(Downsampling downsampling, long startTB) { Review comment: Indeed, it maybe faster to convert to long like 202002. When the timebucket scope in loop statement add one day or month will trouble. Or maybe convert to timestamps,comparing and adding will fast,but also has to convert to Date string. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services