wu-sheng commented on a change in pull request #4353: Optimizing performance
reduces es index queries scope by timebucket
URL: https://github.com/apache/skywalking/pull/4353#discussion_r378091398
##########
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/model/ModelName.java
##########
@@ -30,10 +43,73 @@ public static String build(Downsampling downsampling,
String modelName) {
return modelName + Const.ID_SPLIT + Downsampling.Day.getName();
case Hour:
return modelName + Const.ID_SPLIT +
Downsampling.Hour.getName();
- // case Second:
- // return modelName + Const.ID_SPLIT +
Downsampling.Second.getName();
default:
return modelName;
}
}
+
+ public static String[] build(Downsampling downsampling, String modelName,
long startTB, long endTB) {
Review comment:
This build method is for ES storage only, please move inside the plugin.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
