ad-m commented on a change in pull request #18642:
URL: https://github.com/apache/superset/pull/18642#discussion_r803195078
##########
File path: helm/superset/templates/_helpers.tpl
##########
@@ -89,6 +89,21 @@ WTF_CSRF_ENABLED = True
WTF_CSRF_EXEMPT_LIST = []
# A CSRF token that expires in 1 year
WTF_CSRF_TIME_LIMIT = 60 * 60 * 24 * 365
+{{- if .Values.supersetNode.connections.redis_password }}
+class CeleryConfig(object):
Review comment:
Some lines are duplicated in both condition situations. I wonder if we
want to have two ifs or if we want duplicate code. I think it's better not to
have two ifs than duplicate code, because then it's easier to maintain
consistency when a new parameter is added in the middle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
