wiktor2200 commented on a change in pull request #18642:
URL: https://github.com/apache/superset/pull/18642#discussion_r803633563



##########
File path: helm/superset/templates/_helpers.tpl
##########
@@ -89,6 +89,21 @@ WTF_CSRF_ENABLED = True
 WTF_CSRF_EXEMPT_LIST = []
 # A CSRF token that expires in 1 year
 WTF_CSRF_TIME_LIMIT = 60 * 60 * 24 * 365
+{{- if .Values.supersetNode.connections.redis_password }}
+class CeleryConfig(object):

Review comment:
       It makes sense. I've tried it this way before but I wanted diff to be 
minimal, so I didn't want to change order od parameters. I changed it, because 
I agree that when it will become bigger one of if/else/end could be omitted and 
cause lots of troubleshooting.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to