wiktor2200 commented on a change in pull request #18642:
URL: https://github.com/apache/superset/pull/18642#discussion_r803611055



##########
File path: helm/superset/templates/_helpers.tpl
##########
@@ -89,6 +89,21 @@ WTF_CSRF_ENABLED = True
 WTF_CSRF_EXEMPT_LIST = []
 # A CSRF token that expires in 1 year
 WTF_CSRF_TIME_LIMIT = 60 * 60 * 24 * 365
+{{- if .Values.supersetNode.connections.redis_password }}
+class CeleryConfig(object):
+  BROKER_URL = 
f"redis://{env('REDIS_PASSWORD')}@{env('REDIS_HOST')}:{env('REDIS_PORT')}/0"

Review comment:
       Hmm... that's weird, I tested it in minikube and it worked. I've checked 
logs in both superset and redis (no errors) and info about successfully 
connected clients in redis. 
   ```
   DB 0: 3 keys (0 volatile) in 4 slots HT.
   10 clients connected (0 replicas), 1022392 bytes in use
   ```
   But docs says different thing and you've got right that it's better to stick 
to documentation.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to