kgabryje commented on a change in pull request #19078:
URL: https://github.com/apache/superset/pull/19078#discussion_r823787389
##########
File path:
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx
##########
@@ -309,8 +310,8 @@ class SliceHeaderControls extends React.PureComponent<
{supersetCanShare && (
<ShareMenuItems
- copyMenuItemTitle={t('Copy chart URL')}
- emailMenuItemTitle={t('Share chart by email')}
+ copyMenuItemTitle={t('Copy permalink to clipboard')}
Review comment:
I'm not sure if using a word "permalink" brings value to the end user. I
feel like it might be confusing, and simply saying "link" or "URL" makes the
intention clearer. I'd suggest asking a product manager for an opinion on that.
(applies to changes in ExploreActionButtons too)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
