villebro commented on a change in pull request #19078:
URL: https://github.com/apache/superset/pull/19078#discussion_r823818049
##########
File path:
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx
##########
@@ -309,8 +310,8 @@ class SliceHeaderControls extends React.PureComponent<
{supersetCanShare && (
<ShareMenuItems
- copyMenuItemTitle={t('Copy chart URL')}
- emailMenuItemTitle={t('Share chart by email')}
+ copyMenuItemTitle={t('Copy permalink to clipboard')}
Review comment:
Agreed - I know @michael-s-molina did some investigative work and found
many products use the term. Here's GitHub:
<img width="239" alt="image"
src="https://user-images.githubusercontent.com/33317356/157690243-f402a325-64ed-4bd2-9a53-395186fd263a.png";>
One other thing we may want to consider is removing "to clipboard", as it's
pretty much self evident.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/33317356/157690243-f402a325-64ed-4bd2-9a53-395186fd263a.png"](https://user-images.githubusercontent.com/33317356/157690243-f402a325-64ed-4bd2-9a53-395186fd263a.png"){kind=link}