[GitHub] [superset] michael-s-molina commented on a change in pull request #19078: [WIP] feat: add permalink to dashboard and explore

[GitBox]

michael-s-molina commented on a change in pull request #19078:
URL: https://github.com/apache/superset/pull/19078#discussion_r823791115



##########
File path: 
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx
##########
@@ -309,8 +310,8 @@ class SliceHeaderControls extends React.PureComponent<
 
         {supersetCanShare && (
           <ShareMenuItems
-            copyMenuItemTitle={t('Copy chart URL')}
-            emailMenuItemTitle={t('Share chart by email')}
+            copyMenuItemTitle={t('Copy permalink to clipboard')}

Review comment:
       The inspiration here is coming from Github and Shortcut but we could 
validate as you suggested.
   
   <img width="1752" alt="Screen Shot 2022-03-08 at 10 02 21 AM" 
src="https://user-images.githubusercontent.com/70410625/157685290-ae884bf3-f637-4662-b04c-47aaecd5bc37.png";>
   <img width="671" alt="Screen Shot 2022-03-08 at 10 03 35 AM" 
src="https://user-images.githubusercontent.com/70410625/157685301-99f5a27d-48b5-4a0f-b32a-5753a1c0aadc.png";>
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org