[GitHub] [superset] Antonio-RiveroMartnez commented on a diff in pull request #20627: fix(chart): Time Series set showMaxLabel as null for time xAxis

Tue, 12 Jul 2022 12:14:54 -0700 


Antonio-RiveroMartnez commented on code in PR #20627:
URL: https://github.com/apache/superset/pull/20627#discussion_r919285048


##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts:
##########
@@ -326,13 +327,23 @@ export default function transformProps(
       rotate: xAxisLabelRotation,

Review Comment:
   @stephenLYZ enabling that flag we get the last month to show but the chart 
looks off to me and the format is not correct:
   
   `Changes from this PR:`
   <img width="1273" alt="PR" 
src="https://user-images.githubusercontent.com/38889534/178567647-a19db0e2-e993-4526-9909-29b83e3d49cd.png";>
   
   `No changes + Flag enabled:`
   <img width="1273" alt="Flag" 
src="https://user-images.githubusercontent.com/38889534/178567686-df0ceee2-055c-469c-bf2d-524e436d8be7.png";>
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to