Antonio-RiveroMartnez commented on code in PR #20627:
URL: https://github.com/apache/superset/pull/20627#discussion_r919043905


##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts:
##########
@@ -326,13 +327,23 @@ export default function transformProps(
       rotate: xAxisLabelRotation,

Review Comment:
   I may be mistaken, however, based on this from the README:
   
   ```
   A new feature flag GENERIC_CHART_AXES has been added that makes it possible 
to
     use a non-temporal x-axis on the ECharts Timeseries chart
     ([#17917](https://github.com/apache/superset/pull/17917)). When enabled, a 
new
     control "X Axis" is added to the control panel of ECharts line, area, bar, 
step and
     scatter charts, which makes it possible to use categorical or numerical 
x-axes on
     those charts.
   ```
   
   If that's true those are exactly the axis types we don't want to include 
with these changes. Nonetheless, let me try setting it as true and see if it 
actually fix the issue by itself.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to