Antonio-RiveroMartnez commented on code in PR #20627:
URL: https://github.com/apache/superset/pull/20627#discussion_r918919331
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts:
##########
@@ -326,13 +327,23 @@ export default function transformProps(
rotate: xAxisLabelRotation,
Review Comment:
If you do that you will be overriding default values for other axis types to
`false`. Which might not be the desire output and might impact how other charts
behave. I would rather let the defaults for other types be set in `Echarts` and
respect their criteria and being explicit to overriding only when/where we need
to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
