codyml commented on code in PR #20683:
URL: https://github.com/apache/superset/pull/20683#discussion_r924554979
##########
superset/datasets/commands/samples.py:
##########
@@ -78,3 +116,24 @@ def validate(self) -> None:
security_manager.raise_for_ownership(self._model)
except SupersetSecurityException as ex:
raise DatasetForbiddenError() from ex
+
+ @staticmethod
+ def get_limit_clause(
+ page: Optional[int], per_page: Optional[int]
+ ) -> Dict[str, int]:
+ samples_row_limit = app.config.get("SAMPLES_ROW_LIMIT", 1000)
Review Comment:
Right, and I was suggesting that we ignore `SAMPLES_ROW_LIMIT` for paginated
results so the pages are always the requested size regardless of the
`SAMPLES_ROW_LIMIT` setting (unless they request a very large page size),
otherwise users might be surprised to find that their requested page size isn't
being respected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
