michael-s-molina commented on PR #20683: URL: https://github.com/apache/superset/pull/20683#issuecomment-1192490643
> @codyml @michael-s-molina this is an interesting question, because now it is not dataset samples but different types of datasouce samples, so it should not be put under dataset, ----- introduced different datasource from [PR](https://github.com/apache/superset/pull/20281) ---- That's why I moved it to datasource. Thank you for the explanation @zhaoyongjie. It seems we're missing this new concept in v1 as you said. About deleting the old endpoints. I did something slightly different for the old `/superset/explore` endpoint in `views/core`. I added a [warning indicating that the endpoint will be deprecated in 3.0 and redirected the user to the new endpoint](https://github.com/apache/superset/blob/39545352d29655e8b1c44987ad128c33d1b6eac5/superset/views/core.py#L750). This is debatable because I'm not sure we're considering changes to endpoints that are not under v1 breaking changes. I took the safest approach but I leave the decision to you if you also want to follow a similar pattern or if you don't consider this a breaking change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
