zhaoyongjie commented on code in PR #20683:
URL: https://github.com/apache/superset/pull/20683#discussion_r924573586
##########
superset/datasets/commands/samples.py:
##########
@@ -78,3 +116,24 @@ def validate(self) -> None:
security_manager.raise_for_ownership(self._model)
except SupersetSecurityException as ex:
raise DatasetForbiddenError() from ex
+
+ @staticmethod
+ def get_limit_clause(
+ page: Optional[int], per_page: Optional[int]
+ ) -> Dict[str, int]:
+ samples_row_limit = app.config.get("SAMPLES_ROW_LIMIT", 1000)
Review Comment:
The purpose of the `SAMPLES_ROW_LIMIT` here is to calculate the **page
size** when the user inputs more than `SAMPLES_ROW_LIMIT`, With the correct
page size, the page offset can be calculated ---- and not to calculate the
offset over the `SAMPLES_ROW_LIMIT`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
