lyndsiWilliams commented on code in PR #21557:
URL: https://github.com/apache/superset/pull/21557#discussion_r979087475
##########
superset-frontend/src/views/CRUD/data/dataset/AddDataset/index.tsx:
##########
@@ -71,13 +71,17 @@ export default function AddDataset() {
>(datasetReducer, null);
const HeaderComponent = () => (
- <Header setDataset={setDataset} datasetName={dataset?.dataset_name ?? ''}
/>
+ <Header
+ setDataset={setDataset}
+ title={dataset?.table_name ?? 'New dataset'}
+ schema={dataset?.schema ?? ''}
+ />
);
const LeftPanelComponent = () => (
<LeftPanel
setDataset={setDataset}
- schema={dataset?.schema}
+ schema={dataset?.schema ?? ''}
Review Comment:
Good call, that does make more sense! Fixed in [`this
commit`](https://github.com/apache/superset/pull/21557/commits/7fa31ba609eadb2b9d01a884abc8da57a053ee79).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
