[GitHub] [superset] lyndsiWilliams commented on a diff in pull request #21557: fix: Dataset creation header is now uneditable and holds proper default values

Fri, 23 Sep 2022 14:59:31 -0700 


lyndsiWilliams commented on code in PR #21557:
URL: https://github.com/apache/superset/pull/21557#discussion_r979088255


##########
superset-frontend/src/views/CRUD/data/dataset/DatasetLayout/DatasetLayout.test.tsx:
##########
@@ -36,18 +36,12 @@ describe('DatasetLayout', () => {
   const mockSetDataset = jest.fn();
 
   const waitForRender = () =>
-    waitFor(() =>
-      render(<Header setDataset={mockSetDataset} datasetName="" />),
-    );
+    waitFor(() => render(<Header setDataset={mockSetDataset} title="" />));

Review Comment:
   The title can't have nullish values because of the component that uses it: 
[PageHeaderWithActions](https://github.com/apache/superset/blob/master/superset-frontend/src/components/PageHeaderWithActions/index.tsx)
   
   <img width="707" alt="Screen Shot 2022-09-23 at 4 45 18 PM" 
src="https://user-images.githubusercontent.com/55605634/192060971-27fa04cc-4ff5-4b84-85ff-4168df8327ab.png";>
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to