[GitHub] [superset] lyndsiWilliams commented on a diff in pull request #21557: fix: Dataset creation header is now uneditable and holds proper default values

Fri, 23 Sep 2022 16:39:34 -0700 


lyndsiWilliams commented on code in PR #21557:
URL: https://github.com/apache/superset/pull/21557#discussion_r979119689


##########
superset-frontend/src/views/CRUD/data/dataset/AddDataset/index.tsx:
##########
@@ -71,7 +71,11 @@ export default function AddDataset() {
   >(datasetReducer, null);
 
   const HeaderComponent = () => (
-    <Header setDataset={setDataset} datasetName={dataset?.dataset_name ?? ''} 
/>
+    <Header
+      setDataset={setDataset}
+      title={dataset?.table_name ?? 'New dataset'}

Review Comment:
   Actually, depending on the intended header behavior, we might need to figure 
something else out. If I set the default here to "Undefined dataset" it will 
temporarily change to that once a schema is chosen and a table name isn't 
selected. This could be okay as well though, because _technically_ it is 
undefined at that point. What do you think?
   
   ![2022-09-23 18 35 
06](https://user-images.githubusercontent.com/55605634/192069663-ead646e8-bb12-42d7-ac22-e7362f886cbc.gif)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to