john-bodley commented on code in PR #24705:
URL: https://github.com/apache/superset/pull/24705#discussion_r1267104413
##########
superset/config.py:
##########
@@ -758,11 +758,6 @@ class D3Format(TypedDict, total=False):
# note: index option should not be overridden
CSV_EXPORT = {"encoding": "utf-8"}
-# Excel Options: key/value pairs that will be passed as argument to
DataFrame.to_excel
-# method.
-# note: index option should not be overridden
-EXCEL_EXPORT = {"encoding": "utf-8"}
Review Comment:
The `EXCEL_EXPORT` could include additional keyword arguments other than
`encoding`. The challenge is if any of the other
[DataFrame.to_excel](https://pandas.pydata.org/docs/reference/api/pandas.DataFrame.to_excel.html)
arguments changed, then this PR would be deemed a breaking change and thus we
would need to punt on this PR until Superset 4.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
