john-bodley commented on code in PR #24705:
URL: https://github.com/apache/superset/pull/24705#discussion_r1268753340
##########
tests/unit_tests/pandas_postprocessing/test_rolling.py:
##########
@@ -162,8 +162,8 @@ def test_rolling_after_pivot_with_single_metric():
pd.DataFrame(
data={
"dttm": pd.to_datetime(["2019-01-01", "2019-01-02"]),
- FLAT_COLUMN_SEPARATOR.join(["sum_metric", "UK"]): [5.0, 12.0],
- FLAT_COLUMN_SEPARATOR.join(["sum_metric", "US"]): [6.0, 14.0],
+ FLAT_COLUMN_SEPARATOR.join(["sum_metric", "UK"]): [5, 12],
Review Comment:
NIce! I'm glad to see integers remain integers when summed. Would you mind
updating the comment above as it still references floats.
##########
superset/common/query_context_processor.py:
##########
@@ -134,17 +134,15 @@ def get_df_payload(
if query_obj and cache_key and not cache.is_loaded:
try:
- invalid_columns = [
+ if invalid_columns := [
Review Comment:
Love the walrus.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
