sebastianliebscher commented on code in PR #24705:
URL: https://github.com/apache/superset/pull/24705#discussion_r1268065149
##########
superset/config.py:
##########
@@ -758,11 +758,6 @@ class D3Format(TypedDict, total=False):
# note: index option should not be overridden
CSV_EXPORT = {"encoding": "utf-8"}
-# Excel Options: key/value pairs that will be passed as argument to
DataFrame.to_excel
-# method.
-# note: index option should not be overridden
-EXCEL_EXPORT = {"encoding": "utf-8"}
Review Comment:
Only `encoding` and `verbose` have been removed in 2.0. Both arguments [were
never
used](https://pandas.pydata.org/pandas-docs/version/1.5/reference/api/pandas.DataFrame.to_excel.html).
I will leave `EXCEL_EXPORT` as an empty variable, so users can still set
their custom overrides.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
