sebastianliebscher commented on code in PR #25422:
URL: https://github.com/apache/superset/pull/25422#discussion_r1340377139
##########
.github/workflows/docker_build_push.sh:
##########
@@ -47,13 +47,13 @@ if [ -z "${DOCKERHUB_TOKEN}" ]; then
# Skip if secrets aren't populated -- they're only visible for actions
running in the repo (not on forks)
echo "Skipping Docker push"
# By default load it back
- DOCKER_ARGS="--load"
+ DOCKER_ARGS="--load --cache-from=type=registry,ref=apache/superset:cache"
ARCHITECTURE_FOR_BUILD="linux/amd64 linux/arm64"
else
# Login and push
docker logout
docker login --username "${DOCKERHUB_USER}" --password "${DOCKERHUB_TOKEN}"
- DOCKER_ARGS="--push"
+ DOCKER_ARGS="--push --cache-from=type=registry,ref=apache/superset:cache
--cache-to type=registry,ref=apache/superset:cache,mode=max"
Review Comment:
I am just curious. Doesn't this always overwrite the same image cache during
a single build if using the same `--cache-to` arg for every image? E.g.
`superset:websocket` overwrites `superset:py310`. And right after that,
`superset:dockerize` overwrtites `superset:websocket` etc?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
