alekseyolg commented on code in PR #25422:
URL: https://github.com/apache/superset/pull/25422#discussion_r1341602294


##########
.github/workflows/docker_build_push.sh:
##########
@@ -43,29 +43,35 @@ cat<<EOF
   - ${REPO_NAME}:${LATEST_TAG}
 EOF
 
+CACHE_FROM="--cache-from=type=registry,ref=apache/superset:cache"
 if [ -z "${DOCKERHUB_TOKEN}" ]; then
   # Skip if secrets aren't populated -- they're only visible for actions 
running in the repo (not on forks)
   echo "Skipping Docker push"
   # By default load it back
   DOCKER_ARGS="--load"
-  ARCHITECTURE_FOR_BUILD="linux/amd64 linux/arm64"
 else
   # Login and push
   docker logout
   docker login --username "${DOCKERHUB_USER}" --password "${DOCKERHUB_TOKEN}"
   DOCKER_ARGS="--push"
-  ARCHITECTURE_FOR_BUILD="linux/amd64,linux/arm64"
+  CACHE_TO="--cache-to type=registry,mode=max,ref=apache/superset:cache"

Review Comment:
   Let's then try to build both architectures with a local cache, but I repeat 
- then with each code proposal you will have to wait more than an hour.
   And we can return to the current issue after the group meeting.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to