craig-rueda commented on code in PR #25422:
URL: https://github.com/apache/superset/pull/25422#discussion_r1341533304
##########
.github/workflows/docker_build_push.sh:
##########
@@ -43,29 +43,35 @@ cat<<EOF
- ${REPO_NAME}:${LATEST_TAG}
EOF
+CACHE_FROM="--cache-from=type=registry,ref=apache/superset:cache"
if [ -z "${DOCKERHUB_TOKEN}" ]; then
# Skip if secrets aren't populated -- they're only visible for actions
running in the repo (not on forks)
echo "Skipping Docker push"
# By default load it back
DOCKER_ARGS="--load"
- ARCHITECTURE_FOR_BUILD="linux/amd64 linux/arm64"
else
# Login and push
docker logout
docker login --username "${DOCKERHUB_USER}" --password "${DOCKERHUB_TOKEN}"
DOCKER_ARGS="--push"
- ARCHITECTURE_FOR_BUILD="linux/amd64,linux/arm64"
+ CACHE_TO="--cache-to type=registry,mode=max,ref=apache/superset:cache"
Review Comment:
This will cruft up the `apache/superset` registry and will clobber the tag
with each branch build. Let's just leave the local `cache-to` for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
