rusackas commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1481913845
##########
superset-frontend/src/dashboard/components/DashboardBuilder/DashboardContainer.tsx:
##########
@@ -233,6 +234,18 @@ const DashboardContainer: FC<DashboardContainerProps> = ({
topLevelTabs }) => {
fullWidth={false}
animated={false}
allowOverflow
+ onFocus={e => {
+ if (
+ // prevent scrolling when tabbing to the tab pane
+ e.target.classList.contains('ant-tabs-tabpane') &&
+ window.scrollY < TOP_OF_PAGE_RANGE
+ ) {
+ // prevent window from jumping down when tabbing
+ // if already at the top of the page
+ // to help with accessibility when using keyboard navigation
Review Comment:
OMG comments! ❤️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
