rusackas commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1481961971
##########
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx:
##########
@@ -305,6 +399,7 @@ const SliceHeaderControls = (props:
SliceHeaderControlsPropsWithRouter) => {
case MENU_KEYS.EXPLORE_CHART:
// eslint-disable-next-line no-unused-expressions
props.logExploreChart?.(props.slice.slice_id);
+ window.open(props.exploreUrl, '_blank');
Review Comment:
Is popping open in `_blank` the right default here, or should it open in
the same window?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
