rusackas commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1481972747
##########
superset-frontend/src/dashboard/styles.ts:
##########
@@ -97,3 +111,43 @@ export const chartContextMenuStyles = (theme:
SupersetTheme) => css`
min-width: ${theme.gridUnit * 40}px;
}
`;
+
+export const focusStyle = (theme: SupersetTheme) => css`
+ a,
+ .ant-tabs-tabpane,
+ .ant-tabs-tab-btn,
+ .superset-button.action-button,
+ .superset-button.ant-dropdown-trigger,
+ .header-controls span {
+ &:focus-visible {
+ box-shadow: 0 0 0 2px ${theme.colors.primary.dark1};
+ border-radius: ${theme.gridUnit / 2}px;
+ outline: none;
+ text-decoration: none;
+ }
+ &:not(.superset-button, .ant-menu-item
+ a, .fave-unfave-icon, .ant-tabs-tabpane, .header-controls span) {
+ &:focus-visible {
+ padding: ${theme.gridUnit / 2}px;
+ }
+ }
+ }
+
+ @keyframes fadeOut {
Review Comment:
Oooooh, fancy! Just another "note to self" that we can add shadows to the
theme as well, so they can be appropriate "glows" in dark mode, and be
standardized across the UI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
