kgabryje commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1504591459
##########
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx:
##########
@@ -309,6 +403,7 @@ const SliceHeaderControls = (props:
SliceHeaderControlsPropsWithRouter) => {
case MENU_KEYS.EXPLORE_CHART:
// eslint-disable-next-line no-unused-expressions
props.logExploreChart?.(props.slice.slice_id);
+ window.open(props.exploreUrl);
Review Comment:
In that case, maybe we could set tabIndex=-1 on that particular menu item,
so that tab would focus on the link?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
