kgabryje commented on code in PR #26138: URL: https://github.com/apache/superset/pull/26138#discussion_r1504600244
########## superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx: ########## @@ -170,25 +182,91 @@ const dropdownIconsStyles = css` } `; +export const handleDropdownNavigation = ( Review Comment: I know that this PR is focused on dashboard interactions, but maybe (future iterations) we should add this functionality to the main Dropdown component, so that the keyboard navigation works in all dropdowns? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
