rusackas commented on code in PR #29245:
URL: https://github.com/apache/superset/pull/29245#discussion_r1638994033
##########
superset-frontend/src/components/AsyncAceEditor/AsyncAceEditor.stories.tsx:
##########
@@ -87,11 +87,13 @@ AsyncAceEditor.args = {
AsyncAceEditor.argTypes = {
editorType: {
defaultValue: 'json',
- control: { type: 'select', options: editorTypes },
+ control: { type: 'select' },
+ options: editorTypes,
},
defaultTheme: {
defaultValue: 'github',
- control: { type: 'radio', options: ['textmate', 'github'] },
+ control: { type: 'radio' },
+ options: ['textmate', 'github'],
Review Comment:
I can't even tell if this one is working (they look the same?), but it does
change whatever content you might've typed into the editor itself. I won't lose
too much sleep over that though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
