rusackas commented on code in PR #29245:
URL: https://github.com/apache/superset/pull/29245#discussion_r1638996160
##########
superset-frontend/src/components/Badge/Badge.stories.tsx:
##########
@@ -73,32 +73,32 @@ InteractiveBadge.argTypes = {
status: {
control: {
type: 'select',
- options: [undefined, ...STATUSES],
},
+ options: [undefined, ...STATUSES],
},
size: {
control: {
type: 'select',
- options: SIZES.options,
},
+ options: SIZES.options,
},
color: {
control: {
type: 'select',
- options: [undefined, ...COLORS.options],
},
+ options: [undefined, ...COLORS.options],
},
textColor: {
control: {
type: 'select',
- options: [undefined, ...COLORS.options],
},
+ options: [undefined, ...COLORS.options],
},
count: {
control: {
type: 'select',
- options: [undefined, ...Array(100).keys()],
},
+ options: [undefined, ...Array(100).keys()],
Review Comment:
I'm not even sure what this control does :P
I think for the most part, all your changes in this PR are just fine... I'm
simply trying things out and leaving notes in case you have time/interest to
keep messing with all this.
In this story, the text size one doesn't seem to have any effect. All the
rest of the controls work fine, but I'm not sure why the badge is displaying
more like a bullet than as a "badge" as it is in the "Badge Gallery" story.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
