rusackas commented on code in PR #29245:
URL: https://github.com/apache/superset/pull/29245#discussion_r1639001181
##########
superset-frontend/src/components/PopoverDropdown/PopoverDropdown.stories.tsx:
##########
@@ -68,11 +68,13 @@ export const InteractivePopoverDropdown = (props: Props) =>
{
InteractivePopoverDropdown.argTypes = {
buttonType: {
defaultValue: 'default',
- control: { type: 'radio', options: ['default', 'button'] },
+ control: { type: 'radio' },
+ options: ['default', 'button'],
},
optionType: {
defaultValue: 'default',
- control: { type: 'radio', options: ['default', 'button'] },
+ control: { type: 'radio' },
+ options: ['default', 'button'],
Review Comment:
THese controls LOOK fine, but the story bombs out with an error of
"Cannot read properties of undefined (reading 'find')"
Note that I know none of this is your fault. We kind of forced the Storybook
upgrade through, and it had a lot of unexpected fallout like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
