msyavuz commented on code in PR #33420:
URL: https://github.com/apache/superset/pull/33420#discussion_r2121945191
##########
superset-frontend/src/features/home/Menu.test.tsx:
##########
@@ -255,6 +255,7 @@ test('should render', async () => {
useRedux: true,
useQueryParams: true,
useRouter: true,
+ useTheme: true,
Review Comment:
> oh also during my refactor I noticed some specific tests were doing their
own theme provider wrapping, we should do this consistently in the render
function
There is some funkiness around accessing spec/helpers in packages and some
places it is necessary to have it like
`src/SqlLab/components/ShareSqlLabQuery/ShareSqlLabQuery.test.tsx`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
