mistercrunch commented on code in PR #33420:
URL: https://github.com/apache/superset/pull/33420#discussion_r2122109452
##########
superset-frontend/src/features/home/Menu.test.tsx:
##########
@@ -255,6 +255,7 @@ test('should render', async () => {
useRedux: true,
useQueryParams: true,
useRouter: true,
+ useTheme: true,
Review Comment:
In the new one, I didn't bother implementing a `useTheme` but could be good
depending on overhead. Trying to think about measuring overhead, but maybe
setting "false expect where needed" and comparing the cpu cycles with or
without might be worthwhile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
