mistercrunch commented on code in PR #33420:
URL: https://github.com/apache/superset/pull/33420#discussion_r2121838231
##########
superset-frontend/src/features/home/Menu.test.tsx:
##########
@@ -255,6 +255,7 @@ test('should render', async () => {
useRedux: true,
useQueryParams: true,
useRouter: true,
+ useTheme: true,
Review Comment:
wondering if `true` should be the default arg in the spec/utils render
function (?) Might add extra work/overhead on the test suite but it's nice to
not have to worry and be explicit about it. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
