Re: [PR] feat(deck.gl): Enables Dark Mode for deck gl charts through OSM [superset]

Thu, 14 Aug 2025 05:28:33 -0700 


korbit-ai[bot] commented on code in PR #34697:
URL: https://github.com/apache/superset/pull/34697#discussion_r2276491058


##########
superset-frontend/plugins/legacy-preset-chart-deckgl/src/utilities/Shared_DeckGL.tsx:
##########
@@ -53,6 +53,10 @@ let deckglTiles: string[][];
 export const DEFAULT_DECKGL_TILES = [
   ['https://tile.openstreetmap.org/{z}/{x}/{y}.png', 'Streets (OSM)'],
   ['https://tile.osm.ch/osm-swiss-style/{z}/{x}/{y}.png', 'Topography (OSM)'],
+  [
+    'tile://https://a.basemaps.cartocdn.com/dark_all/{z}/{x}/{y}.png',

Review Comment:
   ### Invalid URL Protocol for Dark Mode Tiles <sub>![category 
Functionality](https://img.shields.io/badge/Functionality-0284c7)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   The URL for the dark OSM tiles is using an invalid 'tile://' protocol prefix 
that could prevent the tiles from loading correctly.
   
   
   ###### Why this matters
   The map tiles may fail to load because the URL protocol is incorrect, 
breaking the dark mode functionality which is the main intent of this change.
   
   ###### Suggested change ∙ *Feature Preview*
   Remove the 'tile://' prefix from the URL:
   ```typescript
   [
       'https://a.basemaps.cartocdn.com/dark_all/{z}/{x}/{y}.png',
       'Dark (OSM)',
   ]
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/02c2add8-0a77-46ea-94de-9f473c07d74e/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/02c2add8-0a77-46ea-94de-9f473c07d74e?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/02c2add8-0a77-46ea-94de-9f473c07d74e?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/02c2add8-0a77-46ea-94de-9f473c07d74e?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/02c2add8-0a77-46ea-94de-9f473c07d74e)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:0f28247e-2192-4d78-95f6-1580578f9fcc -->
   
   
   [](0f28247e-2192-4d78-95f6-1580578f9fcc)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to