rusackas commented on code in PR #34697: URL: https://github.com/apache/superset/pull/34697#discussion_r2289422987
########## superset-frontend/plugins/legacy-preset-chart-deckgl/src/utilities/Shared_DeckGL.tsx: ########## @@ -53,6 +53,10 @@ let deckglTiles: string[][]; export const DEFAULT_DECKGL_TILES = [ ['https://tile.openstreetmap.org/{z}/{x}/{y}.png', 'Streets (OSM)'], ['https://tile.osm.ch/osm-swiss-style/{z}/{x}/{y}.png', 'Topography (OSM)'], + [ + 'tile://https://a.basemaps.cartocdn.com/dark_all/{z}/{x}/{y}.png', Review Comment: Looks fantastic, but... do we need a license (or grant/exemption) for this? I'm _guessing_ it's OK for OSS use, but if a business uses it (often the case!) then i'm not sure what the rules are. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
