korbit-ai[bot] commented on code in PR #34697: URL: https://github.com/apache/superset/pull/34697#discussion_r2289423454
########## superset-frontend/plugins/legacy-preset-chart-deckgl/src/utilities/Shared_DeckGL.tsx: ########## @@ -53,6 +53,10 @@ let deckglTiles: string[][]; export const DEFAULT_DECKGL_TILES = [ ['https://tile.openstreetmap.org/{z}/{x}/{y}.png', 'Streets (OSM)'], ['https://tile.osm.ch/osm-swiss-style/{z}/{x}/{y}.png', 'Topography (OSM)'], + [ + 'tile://https://a.basemaps.cartocdn.com/dark_all/{z}/{x}/{y}.png', Review Comment: Good point. CartoDB's basemaps require proper attribution and have usage limits under their Free plan. For commercial use, organizations need a paid CartoDB plan or explicit permission. We should: 1. Add required attribution for the tiles 2. Document usage limitations in README 3. Consider alternatives like Mapbox (already supported) for commercial deployments See CartoDB's terms: https://carto.com/legal/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
