msyavuz commented on code in PR #35123:
URL: https://github.com/apache/superset/pull/35123#discussion_r2345235675
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts:
##########
@@ -289,6 +293,12 @@ export function transformSeries(
isConfidenceBand || (stack === StackControlsValue.Stream && area)
? { ...opts.lineStyle, opacity: OpacityEnum.Transparent }
: { ...opts.lineStyle, opacity };
+
+ // Use filled circles in dark mode to avoid the white fill issue with hollow
circles
+ // Use emptyCircle explicitly in light mode
+ const symbol =
+ plotType === 'line' ? (isDarkMode ? 'circle' : 'emptyCircle') : undefined;
Review Comment:
This seems like a good suggestion @gabotorresruiz. Otherwise LGTM!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
