gabotorresruiz commented on code in PR #35123:
URL: https://github.com/apache/superset/pull/35123#discussion_r2345271537
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts:
##########
@@ -289,6 +293,12 @@ export function transformSeries(
isConfidenceBand || (stack === StackControlsValue.Stream && area)
? { ...opts.lineStyle, opacity: OpacityEnum.Transparent }
: { ...opts.lineStyle, opacity };
+
+ // Use filled circles in dark mode to avoid the white fill issue with hollow
circles
+ // Use emptyCircle explicitly in light mode
+ const symbol =
+ plotType === 'line' ? (isDarkMode ? 'circle' : 'emptyCircle') : undefined;
Review Comment:
@msyavuz actually `symbol type` and `showSymbol` are independent settings in
`ECharts`:
- `symbol` defines what shape to use (circle, emptyCircle, etc.)
- `showSymbol` controls whether symbols appear on the line itself
- `Legends` always show symbols regardless of showSymbol
The suggested change `(showSymbol && plotType === 'line')` would break
legends when `showSymbol = false` because it would set `symbol = undefined`,
causing `ECharts` to fall back to its default symbol (which has the white fill
bug in dark mode).
The fix is specifically for legend display, not line display. Charts with
`showSymbol = false` will still hide symbols on the line. They just need the
correct symbol type defined for when it appears in the legend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
