Re: [PR] fix(charts): fix legend theming and hollow symbols in dark mode [superset]

Sat, 20 Sep 2025 09:23:36 -0700 


korbit-ai[bot] commented on code in PR #35123:
URL: https://github.com/apache/superset/pull/35123#discussion_r2345167439


##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts:
##########
@@ -289,6 +293,12 @@ export function transformSeries(
     isConfidenceBand || (stack === StackControlsValue.Stream && area)
       ? { ...opts.lineStyle, opacity: OpacityEnum.Transparent }
       : { ...opts.lineStyle, opacity };
+
+  // Use filled circles in dark mode to avoid the white fill issue with hollow 
circles
+  // Use emptyCircle explicitly in light mode
+  const symbol =
+    plotType === 'line' ? (isDarkMode ? 'circle' : 'emptyCircle') : undefined;

Review Comment:
   ### Symbol Type Override Ignores showSymbol Setting <sub>![category 
Functionality](https://img.shields.io/badge/Functionality-0284c7)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   The symbol type change in dark mode applies to all line charts, but should 
only apply to charts with showSymbol=true to avoid unintended symbol displays.
   
   
   ###### Why this matters
   Currently, even charts that are meant to hide symbols might show them in 
dark mode, affecting the visual representation and potentially causing 
confusion.
   
   ###### Suggested change ∙ *Feature Preview*
   Update the symbol type logic to respect the showSymbol setting:
   ```typescript
   const symbol = showSymbol && plotType === 'line' ? (isDarkMode ? 'circle' : 
'emptyCircle') : undefined;
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/818883eb-5637-42e4-87c0-2609cd821072/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/818883eb-5637-42e4-87c0-2609cd821072?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/818883eb-5637-42e4-87c0-2609cd821072?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/818883eb-5637-42e4-87c0-2609cd821072?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/818883eb-5637-42e4-87c0-2609cd821072)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:16715a2a-a4ad-471e-99d5-c85d9c9281d3 -->
   
   
   [](16715a2a-a4ad-471e-99d5-c85d9c9281d3)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to