msyavuz commented on code in PR #35159:
URL: https://github.com/apache/superset/pull/35159#discussion_r2360478120
##########
superset-frontend/src/pages/AlertReportList/index.tsx:
##########
@@ -271,8 +271,7 @@ function AlertList({
},
}: any) =>
lastEvalDttm
- ? extendedDayjs
- .utc(lastEvalDttm)
+ ? (extendedDayjs.utc(lastEvalDttm) as any)
Review Comment:
Is this necessary? It should work without `as any`
##########
superset-frontend/src/pages/QueryHistoryList/index.tsx:
##########
@@ -239,7 +239,7 @@ function QueryList({ addDangerToast }: QueryListProps) {
original: { start_time },
},
}: any) => {
- const start = extendedDayjs.utc(start_time).local();
+ const start = ((extendedDayjs as any).utc(start_time) as
any).local();
Review Comment:
This too
##########
superset-frontend/src/pages/QueryHistoryList/index.tsx:
##########
@@ -267,9 +267,9 @@ function QueryList({ addDangerToast }: QueryListProps) {
const startTime = start_running_time || start_time;
const timerTime =
end_time && startTime
- ? extendedDayjs(extendedDayjs.utc(end_time - startTime)).format(
- TIME_WITH_MS,
- )
+ ? extendedDayjs(
+ (extendedDayjs as any).utc(end_time - startTime),
+ ).format(TIME_WITH_MS)
Review Comment:
i think these might be leftovers from a debugging step earlier?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
