michael-s-molina commented on code in PR #35159:
URL: https://github.com/apache/superset/pull/35159#discussion_r2369556253
##########
.github/workflows/superset-frontend.yml:
##########
@@ -143,7 +143,7 @@ jobs:
- name: tsc
run: |
docker run --rm $TAG bash -c \
- "npm run type"
+ "npm run plugins:build && npm run type"
Review Comment:
@rusackas I think correctness beats slowness in this case as if a plugin
type changed, we need to rebuild them in order for `npm run type` to work. If
you know a faster way of doing that while generating the types when needed, it
would be awesome.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
