mistercrunch commented on code in PR #35159:
URL: https://github.com/apache/superset/pull/35159#discussion_r2371236751
##########
.github/workflows/superset-frontend.yml:
##########
@@ -143,7 +143,7 @@ jobs:
- name: tsc
run: |
docker run --rm $TAG bash -c \
- "npm run type"
+ "npm run plugins:build && npm run type"
Review Comment:
Touched up some things here https://github.com/apache/superset/pull/35240 to
improve devex, I think I got webpack to watch/auto-compile `plugins/` and
`packages/` and now running the type checker inline by default as part of `npm
run dev`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
