mistercrunch opened a new pull request, #35237: URL: https://github.com/apache/superset/pull/35237
The Flask flash message system is a legacy feature from when Superset was a server-rendered application. In the current SPA architecture, these messages are never displayed to users because: - Flash messages only render on page load via FlashProvider's componentDidMount - Modern UI interactions use async API calls that don't trigger page reloads - The main consumer (/explore/ POST endpoint) is already marked @deprecated All user-facing notifications are already handled by the frontend toast system, including chart save operations (see saveModalActions.ts) which dispatches success toasts for: - Chart saved/overwritten - Chart added to dashboard - New dashboard created with chart Changes: - Backend: Removed all flash() calls from views (14 occurrences in 4 files) - Backend: Converted error flashes to JSON responses or logging - Backend: Removed redirect_with_flash utility function - Frontend: Deleted FlashProvider component and tests - Frontend: Removed flash_messages from CommonBootstrapData type - Frontend: Cleaned up context providers and test fixtures - Frontend: Removed unused getBootstrapData imports The application now relies entirely on client-side toast notifications for user feedback, which properly support async operations and provide a consistent UX. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
