mistercrunch commented on code in PR #35237:
URL: https://github.com/apache/superset/pull/35237#discussion_r2373790294
##########
superset-frontend/src/dashboard/actions/hydrate.js:
##########
@@ -274,7 +274,6 @@ export const hydrateDashboard =
superset_can_csv: findPermission('can_csv', 'Superset', roles),
common: {
// legacy, please use state.common instead
- flash_messages: common?.flash_messages,
Review Comment:
Answer is case by case, but short answer is "as they should" from async
calls. Checked that most had been re-implemented the right way since they were
used. Also confirmed that old mechanics are to surface "on the next page load",
which has very few pre-determined triggers, stuff like logging in maybe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
