mistercrunch commented on code in PR #35237:
URL: https://github.com/apache/superset/pull/35237#discussion_r2374651418
##########
superset/views/base.py:
##########
@@ -596,7 +591,7 @@ def _delete(self: BaseView, primary_key: int) -> None:
try:
self.pre_delete(item)
except Exception as ex: # pylint: disable=broad-except
- flash(str(ex), "danger")
+ logger.error("Pre-delete error: %s", str(ex))
Review Comment:
this probably never should have gone through to user
##########
superset/views/base.py:
##########
@@ -629,7 +623,7 @@ def muldelete(self: BaseView, items: list[Model]) ->
FlaskResponse:
try:
self.pre_delete(item)
except Exception as ex: # pylint: disable=broad-except
- flash(str(ex), "danger")
+ logger.error("Pre-delete error: %s", str(ex))
Review Comment:
this probably never should have gone through to user
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
