mistercrunch commented on code in PR #35159:
URL: https://github.com/apache/superset/pull/35159#discussion_r2371114081


##########
.github/workflows/superset-frontend.yml:
##########
@@ -143,7 +143,7 @@ jobs:
       - name: tsc
         run: |
           docker run --rm $TAG bash -c \
-          "npm run type"
+          "npm run plugins:build && npm run type"

Review Comment:
   Seems we need to adjust pre-commit and other things, or is there any way to 
get webpack do also rebuilt this automatically the same way it rebuilds 
everything else?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to