mistercrunch commented on code in PR #35237:
URL: https://github.com/apache/superset/pull/35237#discussion_r2373797006
##########
superset/views/auth.py:
##########
@@ -66,7 +65,7 @@ def activation(self, activation_hash: str) ->
WerkzeugResponse:
reg = self.appbuilder.sm.find_register_user(activation_hash)
if not reg:
logger.error(LOGMSG_ERR_SEC_NO_REGISTER_HASH, activation_hash)
- flash(as_unicode(self.false_error_message), "danger")
+ logger.error("Registration activation failed: %s",
self.false_error_message)
Review Comment:
Let me confirm that logging in is a SPA operation as it should be as opposed
to a backend-round-trip.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
