sadpandajoe commented on code in PR #35800:
URL: https://github.com/apache/superset/pull/35800#discussion_r2453038096
##########
superset/commands/report/execute.py:
##########
@@ -849,10 +878,14 @@ def next(self) -> None:
try:
self.send()
self.update_report_schedule_and_log(ReportState.SUCCESS)
+ except ReportScheduleUnexpectedError:
+ # Don't try to log again if logging itself failed
+ raise
Review Comment:
From codex
> when the fallback update_report_schedule_and_log hits the new
StaleDataError path, the broad except Exception as ex is pre-empted and the
caller never sees ex. We still want the StaleDataError handling, but after
rolling back we should bubble up the original ex so schedule failures remain
diagnosable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
